Possible overflow

Place to report bugs in MoM IME and suggest ideas for enhancements (please read rules before posting)
Locked
aggelon
Posts: 71
Joined: Tue May 16, 2006 6:58 pm
Location: FRANCE
Contact:

Possible overflow

Post by aggelon »

The lenght of the player's name is not checked when key-in, and the game can only display 36 letters (http://aggelonware.free.fr/mom/ime/screen17.jpg), beyond 36, the first ones are droped... and with a great lenght, the game crash (http://aggelonware.free.fr/mom/ime/screen18.jpg)... I did not find WHERE, I though an overflow within a function (like a socket or sometinhg like this), but 1 time, I got a strange behavior : after the game crashed, I was not able to launch it again and always got the same error msg (http://aggelonware.free.fr/mom/ime/screen21.jpg), even after reboot the PC !!!
So I though to a corrupted file (maybe left in the TEMP directory), but a simple 'repair' function of the "Install Client" repaired the bug...


Agg.
User avatar
Implode
Site Admin
Posts: 433
Joined: Fri Feb 24, 2006 3:35 am
Location: Newfoundland, Canada
Contact:

Re: Possible overflow

Post by Implode »

aggelon wrote:The lenght of the player's name is not checked when key-in, and the game can only display 36 letters (http://aggelonware.free.fr/mom/ime/screen17.jpg), beyond 36, the first ones are droped... and with a great lenght, the game crash (http://aggelonware.free.fr/mom/ime/screen18.jpg)...
You're really trying to crash it aren't you :x But yes, you're right, the space for holding player names is "only" 100 chars long and there's no range checking on it, so if you enter a name 101 chars long it'll probably crash in some weird and wonderful way. That's easy to fix so I'll do so. However it might not have been the long player name that caused that thread locking order error, I wouldn't be at all surprised if there was still ways to get those errors. If you find a way to consistently reproduce any, please let me know so I can take a look at them.
aggelon wrote:I did not find WHERE, I though an overflow within a function (like a socket or sometinhg like this), but 1 time, I got a strange behavior : after the game crashed, I was not able to launch it again and always got the same error msg (http://aggelonware.free.fr/mom/ime/screen21.jpg), even after reboot the PC !!!
So I though to a corrupted file (maybe left in the TEMP directory), but a simple 'repair' function of the "Install Client" repaired the bug...
Wow that's weird/scary... I can't explain that... and I don't wish to try it on my PC in case it corrupts my own environment!

Implode.
aggelon
Posts: 71
Joined: Tue May 16, 2006 6:58 pm
Location: FRANCE
Contact:

Post by aggelon »

Bah... actually your 0.8.7 is about stable and playable, and out of the bugs or ToDo you have already listed, it seems difficult to find some new... The beta-tests are limited :( I have to look for abnormal program usages...

I'm trying to check everywhere an user could key-in an error.

I keep in mind it is a "Minor Bugs" forum, and effectively, it seems there is NO BIG ones :)

I have done a very very good job, and it is very nice to see and to play...

Aggelon.
Locked